Messages in this thread | | | Date | Sat, 23 Jun 2007 13:51:22 +0200 | From | Bernhard Fischer <> | Subject | Re: [Linux-fbdev-devel] [PATCH 3/4] fbdev: uvesafb driver |
| |
On Sat, Jun 23, 2007 at 12:52:43PM +0200, Michal Januszewski wrote:
>+static void uvesafb_cn_callback(void *data) >+{ >+ struct cn_msg *msg = (struct cn_msg *)data; >+ struct uvesafb_task *utask = (struct uvesafb_task *)msg->data; >+ struct uvesafb_ktask *task; >+ >+ if (msg->seq >= UVESAFB_TASKS_MAX) >+ return; >+ >+ task = uvfb_tasks[msg->seq]; >+ >+ if (!task || msg->ack != task->ack) >+ return;
You need utask only here, so could spare setting it before the checking above. >+ >+ memcpy(&task->t, utask, sizeof(struct uvesafb_task)); >+ >+ if (task->t.buf_len && task->buf) >+ memcpy(task->buf, ((u8*)utask) + sizeof(struct uvesafb_task), >+ task->t.buf_len); >+ >+ complete(task->done); >+ return; >+} - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |