lkml.org 
[lkml]   [2007]   [Jun]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [31/37] Large blocksize support: Core piece
On Wed, 20 Jun 2007, Bob Picco wrote:

> > + if (size > (PAGE_SIZE << MAX_ORDER) || size < 512 ||
> > + !is_power_of_2(size))
> I think this should be:
> if (size > (MAX_ORDER_NR_PAGES << PAGE_SHIFT) ...
> or
> if (size > (PAGE_SIZE << (MAX_ORDER - 1)) ...
> bob
> > return -EINVAL;


Right.... MAX_ORDER is the first illegal order not the last usable.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-06-21 07:29    [W:0.044 / U:1.296 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site