lkml.org 
[lkml]   [2007]   [Jun]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] fix req->cmd == INT cases
    On Wed, Jun 20 2007, Christoph Hellwig wrote:
    > On Wed, Jun 20, 2007 at 01:53:32PM +0300, Boaz Harrosh wrote:
    > > Jens Axboe wrote:
    > > >
    > > > If you look at most of the code, it's inside ifdef debug statements or
    > > > comments most of them. So I don't think you can base any removal
    > > > suggestion on that.
    > > >
    > > > The patch itself looks fine though, if you send one that isn't mangled
    > > > I'll apply it to the 2.6.23 branch.
    > > >
    > > Sorry new Thunderbird Installation. I forgot it does that.
    > >
    > > - I have unearthed very old bugs in stale drivers that still
    > > used request->cmd as a READ|WRITE int
    > > - This patch is maybe a proof that these drivers have not been
    > > used for a long time. Should they be removed completely?
    > >
    > > Drivers that currently do not work for sure:
    > > drivers/acorn/block/fd1772.c
    > > drivers/acorn/block/mfmhd.c
    >
    > Afaik these are old arm26 driver, and that port is dead and should
    > probably be removed from the tree entirely.
    >
    > > drivers/cdrom/aztcd.c
    > > drivers/cdrom/cm206.c
    > > drivers/cdrom/gscd.c
    > > drivers/cdrom/mcdx.c
    > > drivers/cdrom/optcd.c
    > > drivers/cdrom/sjcd.c
    >
    > These are old cdrom drivers that are broken in various ways and probably
    > should be killed off aswell.

    I agree (with both sentiments), would anyone mind if I just killed them
    off? mitsumi support is being reworked, that can get reintroduced once
    the driver is in a stable state.

    --
    Jens Axboe

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-06-20 14:27    [W:3.718 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site