Messages in this thread | | | Date | Tue, 19 Jun 2007 19:03:25 +0900 | From | Keiichi KII <> | Subject | Re: [RFC][PATCH -mm take5 3/7] add interface for netconsole using sysfs |
| |
Hello Satyam,
First, I'm sorry I couldn't reply to your comments. I'm so appreciate for your comments.
I will fix my patches following your advices. But, I have some questions on the another patches. So, I want to ask you some questions and answer your questions.
>> +static int miscdev_configured; > > Is this really required? We just return with error if misc_register() > fails during module init time itself, so it's not really useful ever, is > it?
You're right. It isn't required.
Thanks -- Keiichi KII NEC Corporation OSS Platform Development Division E-mail: k-keiichi@bx.jp.nec.com
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |