Messages in this thread | | | Date | Tue, 19 Jun 2007 14:51:25 +0200 (CEST) | From | Geert Uytterhoeven <> | Subject | Re: [patch 4/6] ps3: Disk Storage Driver |
| |
On Tue, 19 Jun 2007, Christoph Hellwig wrote: > On Fri, Jun 15, 2007 at 01:39:23PM +0200, Geert Uytterhoeven wrote: > > From: Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com> > > > > Add a Disk Storage Driver for the PS3: > > - Implemented as a block device driver with a dynamic major > > - Disk names (and partitions) are of the format ps3d%c(%u) > > - Uses software scatter-gather with a 64 KiB bounce buffer as the hypervisor > > doesn't support scatter-gather > > Looks good to me. Only nitpicks are: > > - ps3disk_priv should probably be an inline function instead of a macro
I used a macro because you can do
ps3disk_pri(dev) = ...;
With kind regards,
Geert Uytterhoeven Software Architect
Sony Network and Software Technology Center Europe The Corporate Village · Da Vincilaan 7-D1 · B-1935 Zaventem · Belgium
Phone: +32 (0)2 700 8453 Fax: +32 (0)2 700 8622 E-mail: Geert.Uytterhoeven@sonycom.com Internet: http://www.sony-europe.com/
Sony Network and Software Technology Center Europe A division of Sony Service Centre (Europe) N.V. Registered office: Technologielaan 7 · B-1840 Londerzeel · Belgium VAT BE 0413.825.160 · RPR Brussels Fortis Bank Zaventem · Swift GEBABEBB08A · IBAN BE39001382358619 | |