Messages in this thread | | | Date | Mon, 18 Jun 2007 19:11:01 +0100 | From | Christoph Hellwig <> | Subject | Re: [patch] use __asm__ and __volatile__ in i386/arm/s390 byteorder.h |
| |
On Mon, Jun 18, 2007 at 01:24:24AM +0200, Arnd Bergmann wrote: > On Monday 18 June 2007, Arjan van de Ven wrote: > > > > On Sun, 2007-06-17 at 18:33 -0400, Mike Frysinger wrote: > > > This changes asm() to __asm__() and volatile to __volatile__ so that these > > > headers can be used with gcc's -std=c99. > > > > hmm but the kernel doesn't use -std=c99... > > The byteorder headers are exported to user space through > include/asm-generic/Kbuild.asm, and they are used by a number > of other exported headers, so they should work with any > gcc flags that a user might want to use.
No, they should not be exported and the headers using them should be fixed to not require this. Userspace has it's own endianess handling already.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |