Messages in this thread | | | Date | Sun, 17 Jun 2007 21:26:01 -0700 | From | Randy Dunlap <> | Subject | Re: [PATCH] blink: Only blink when parameter is set |
| |
On Sun, 17 Jun 2007 10:39:04 +0200 Bernhard Walle wrote:
> This patch in the blink driver changes the module to only blink when > the parameter 'blink' is set to true. This is to allow the module to > be compiled in the kernel and not as module. > > As the blink module was initially written for kdump, and as the kernel > is relocatable on lots of architectures, there's no need to compile a > separate kdump kernel. The blinking can now enabled via the boot > command line for the kdump kernel when necessary. > > The patch also adds some author/license information and marks the init > function as '__init'. > > Signed-off-by: Bernhard Walle <bwalle@suse.de> > > --- > drivers/misc/blink.c | 13 ++++++++++++- > 1 file changed, 12 insertions(+), 1 deletion(-) > > --- a/drivers/misc/blink.c > +++ b/drivers/misc/blink.c > @@ -3,6 +3,10 @@ > #include <linux/timer.h> > #include <linux/jiffies.h> > > +static int blink = 0;
no need to init to 0.
> +module_param(blink, bool, S_IRUGO); > +MODULE_PARM_DESC(blink, "Enable blinking (without that, the module does nothing)\n");
unneeded "\n"
--- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |