lkml.org 
[lkml]   [2007]   [Jun]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 58/58] KVM: VMX: Ensure vcpu time stamp counter is monotonous
    Date
    If the time stamp counter goes backwards, a guest delay loop can become
    infinite. This can happen if a vcpu is migrated to another cpu, where
    the counter has a lower value than the first cpu.

    Since we're doing an IPI to the first cpu anyway, we can use that to pick
    up the old tsc, and use that to calculate the adjustment we need to make
    to the tsc offset.

    Signed-off-by: Avi Kivity <avi@qumranet.com>
    ---
    drivers/kvm/vmx.c | 9 +++++++++
    1 files changed, 9 insertions(+), 0 deletions(-)

    diff --git a/drivers/kvm/vmx.c b/drivers/kvm/vmx.c
    index 0b2aace..d06c362 100644
    --- a/drivers/kvm/vmx.c
    +++ b/drivers/kvm/vmx.c
    @@ -160,6 +160,7 @@ static void __vcpu_clear(void *arg)
    vmcs_clear(vcpu->vmcs);
    if (per_cpu(current_vmcs, cpu) == vcpu->vmcs)
    per_cpu(current_vmcs, cpu) = NULL;
    + rdtscll(vcpu->host_tsc);
    }

    static void vcpu_clear(struct kvm_vcpu *vcpu)
    @@ -376,6 +377,7 @@ static void vmx_vcpu_load(struct kvm_vcpu *vcpu)
    {
    u64 phys_addr = __pa(vcpu->vmcs);
    int cpu;
    + u64 tsc_this, delta;

    cpu = get_cpu();

    @@ -409,6 +411,13 @@ static void vmx_vcpu_load(struct kvm_vcpu *vcpu)

    rdmsrl(MSR_IA32_SYSENTER_ESP, sysenter_esp);
    vmcs_writel(HOST_IA32_SYSENTER_ESP, sysenter_esp); /* 22.2.3 */
    +
    + /*
    + * Make sure the time stamp counter is monotonous.
    + */
    + rdtscll(tsc_this);
    + delta = vcpu->host_tsc - tsc_this;
    + vmcs_write64(TSC_OFFSET, vmcs_read64(TSC_OFFSET) + delta);
    }
    }

    --
    1.5.0.6
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-06-17 12:03    [W:0.040 / U:77.396 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site