lkml.org 
[lkml]   [2007]   [Jun]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 49/58] KVM: Fix adding an smp virtual machine to the vm list
    Date
    If we add the vm once per vcpu, we corrupt the list if the guest has
    multiple vcpus.

    Signed-off-by: Avi Kivity <avi@qumranet.com>
    ---
    drivers/kvm/kvm_main.c | 6 +++---
    1 files changed, 3 insertions(+), 3 deletions(-)

    diff --git a/drivers/kvm/kvm_main.c b/drivers/kvm/kvm_main.c
    index 3ff8ee5..230b25a 100644
    --- a/drivers/kvm/kvm_main.c
    +++ b/drivers/kvm/kvm_main.c
    @@ -319,6 +319,9 @@ static struct kvm *kvm_create_vm(void)

    spin_lock_init(&kvm->lock);
    INIT_LIST_HEAD(&kvm->active_mmu_pages);
    + spin_lock(&kvm_lock);
    + list_add(&kvm->vm_list, &vm_list);
    + spin_unlock(&kvm_lock);
    for (i = 0; i < KVM_MAX_VCPUS; ++i) {
    struct kvm_vcpu *vcpu = &kvm->vcpus[i];

    @@ -326,9 +329,6 @@ static struct kvm *kvm_create_vm(void)
    vcpu->cpu = -1;
    vcpu->kvm = kvm;
    vcpu->mmu.root_hpa = INVALID_PAGE;
    - spin_lock(&kvm_lock);
    - list_add(&kvm->vm_list, &vm_list);
    - spin_unlock(&kvm_lock);
    }
    return kvm;
    }
    --
    1.5.0.6
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-06-17 12:01    [W:0.020 / U:62.336 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site