lkml.org 
[lkml]   [2007]   [Jun]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH] hwmon/coretemp: Fix a broken error path
    From
    Date
    On Sat, 2007-06-16 at 23:17 +0200, Jean Delvare wrote:
    > Hi Soeren,

    Hi Jean,

    [...]

    > Thanks for reporting. Indeed this patch is broken, sorry for
    > overlooking it. I tested it but my hardware is such that the faulty
    > error path was never taken. Please test the following patch (on top of
    > git-current) and confirm it fixes your problem:
    >
    > Signed-off-by: Jean Delvare <khali@linux-fr.org>
    > Cc: Rudolf Marek <r.marek@assembler.cz>
    > ---
    > drivers/hwmon/coretemp.c | 1 +
    > 1 file changed, 1 insertion(+)
    >
    > --- linux-2.6.22-rc4.orig/drivers/hwmon/coretemp.c 2007-06-05 10:25:54.000000000 +0200
    > +++ linux-2.6.22-rc4/drivers/hwmon/coretemp.c 2007-06-16 23:14:06.000000000 +0200
    > @@ -185,6 +185,7 @@ static int __devinit coretemp_probe(stru
    > /* check for microcode update */
    > rdmsr_on_cpu(data->id, MSR_IA32_UCODE_REV, &eax, &edx);
    > if (edx < 0x39) {
    > + err = -ENODEV;
    > dev_err(&pdev->dev,
    > "Errata AE18 not fixed, update BIOS or "
    > "microcode of the CPU!\n");

    this patch indeed fixes the problem. Thanks!

    Unfortunately the coretemp sensors are simply never there when that
    patch is applied... which I guess was the intention ... As apple
    probably won't update the bios does anyone know how to get a newer
    microcode for a core duo cpu (not core 2 duo!) ?

    Soeren
    --
    Sometimes, there's a moment as you're waking, when you become aware of
    the real world around you, but you're still dreaming.
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-06-17 11:19    [W:0.024 / U:1.080 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site