lkml.org 
[lkml]   [2007]   [Jun]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: w1_therm_read_bin: suspicious usage of flush_signals()
On Thu, Jun 14, 2007 at 09:24:39PM +0400, Oleg Nesterov (oleg@tv-sign.ru) wrote:
> drivers/w1/slaves/w1_therm.c:w1_therm_read_bin()
>
> while (tm) {
> tm = msleep_interruptible(tm);
> if (signal_pending(current))
> flush_signals(current);
> }
>
> current is user-space task, yes?
>
> this looks just wrong, could you please explain?

Hi Oleg.

Well, it can be uninterruptible sleep, but why?
It is not allowed to return to userspace until transaction is completed,
so having uninterruptible sleep will result in exactly same lost of
signals.

> Oleg.

--
Evgeniy Polyakov
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-06-15 06:31    [W:0.101 / U:0.284 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site