Messages in this thread | | | Date | Sun, 10 Jun 2007 15:14:02 +0200 | From | Jan-Benedict Glaw <> | Subject | Re: [PATCH] drivers/isdn/hisax: ARRAY_SIZE instead of sizeof |
| |
On Sun, 2007-06-10 15:11:22 +0200, Karsten Keil <kkeil@suse.de> wrote: > > --- a/drivers/isdn/hisax/callc.c > > +++ b/drivers/isdn/hisax/callc.c > > @@ -834,7 +834,7 @@ static struct FsmNode fnlist[] __initdata = > > }; > > /* *INDENT-ON* */ > > > > -#define FNCOUNT (sizeof(fnlist)/sizeof(struct FsmNode)) > > +#define FNCOUNT ARRAY_SIZE(fnlist) > > > > int __init > > CallcNew(void) > > This is OK, thanks for changing.
I'd suggest to not use another define, but use ARRAY_SIZE(foo) _instead of_ eg. FNCOUNT.
MfG, JBG
-- Jan-Benedict Glaw jbglaw@lug-owl.de +49-172-7608481 Signature of: Ich hatte in letzter Zeit ein bißchen viel Realitycheck. the second : Langsam möchte ich mal wieder weiterträumen können. -- Maximilian Wilhelm (18. Mai 2006, #lug-owl.de) [unhandled content-type:application/pgp-signature] | |