Messages in this thread | | | Date | Sun, 10 Jun 2007 10:57:12 +0000 | From | Pavel Machek <> | Subject | Re: [KJ] [PATCH] drivers/acpi: sizeof/sizeof array size calculations replaced with ARRAY_SIZE |
| |
Hi!
> > > > Any reason to not just replace ACPI_RSD_TABLE_SIZE with ARRAY_SIZE? > > > > Probably because ARRAY_SIZE doesn't exist in ACPICA, which is > > where this code comes from... > > > > When we change syntax in ACPICA files in Linux to make it more "beautiful", > > then it creates more work for me -- as forever on, that syntax difference > > must be manually compared to upstream ACPICA and Linux -- and that syntax > > difference causes upstream patches to no longer apply and require > > hand merging. > > Or we could stop that ACPCICA crap ASAP. The acpi code not only looks > like crap because of that but it's buggy as hell now.
+1.
Len, acpi subsystem is old enough to live by kernel standards, and important enough that it should look&feel like a kernel code. It also does not seem to change quickly, so merging patches should not be a big deal. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |