Messages in this thread | | | Date | Sun, 10 Jun 2007 10:50:24 -0700 | From | Randy Dunlap <> | Subject | Re: [PATCH 0/7] Cleanup code to replace DPRINTK with pr_debug |
| |
On Fri, 08 Jun 2007 23:18:31 +0100 Jack Stone wrote:
> This patch series replaces DPRINTK with pr_debug in alternative.c, > autofs, autofs4 > and ncpfs. A new function called pr_err is also added to keep > functionality in > ncpfs. The last 2 patches add support for pr_debug_pid and apply it to > autofs4 to > keep the output the same as the current DPRINTK statements. > > All patches have been compile tested but not boot tested
Hi,
Doesn't this move printk-debug control from local source files (i.e., targeted, specific ones) to a more global control (DEBUG)?
If so, I don't see that as a generally good thing.
If not, please correct me and tell me how this is useful to just one instance of using pr_debug() in say, ncpfs, without pr_debug() being enabled throughout the entire kernel tree.
Thanks. --- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |