Messages in this thread | | | Date | Fri, 1 Jun 2007 16:42:02 -0700 (PDT) | From | Christoph Lameter <> | Subject | Re: [RFC] [PATCH] cpuset operations causes Badness at mm/slab.c:777 warning |
| |
On Fri, 1 Jun 2007, Linus Torvalds wrote:
> No, I don't think you can do it this way.
Ultimately not. But its worth to see if this works.
> At a minimum, you'd need to test that the result is word-aligned. > Preferably 8-byte aligned. We literally have stuff that knows about these > things and uses the low bits in the pointer to keep extra data.
kmalloc allocations are guaranteed to be aligned to KMALLOC_MINALIGN. I can bring that in but it will make the patch less readable.
> Of course, there migth be other (even more subtle) cases where we just > assume certain alignment, and depend on the fact that we just _happen_ to > get it. Who knows..
I tried to get rid of those cased and I hope that work is complete in 2.6.22.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |