lkml.org 
[lkml]   [2007]   [Jun]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH 2.6.21 1/3] x86_64: EFI64 support
    Date

    Sorry for the late replay I missed this patch series going by the first time.
    > +static efi_status_t
    > +phys_efi_set_virtual_address_map(unsigned long memory_map_size,
    > + unsigned long descriptor_size,
    > + u32 descriptor_version,
    > + efi_memory_desc_t *virtual_map)
    > +{
    > + efi_status_t status;
    > +
    > + efi_call_phys_prelog();
    > + status = efi_call_phys(efi_phys.set_virtual_address_map,
    > + EFI_ARG_NUM_SET_VIRTUAL_ADDRESS_MAP,
    > + (unsigned long)memory_map_size,
    > + (unsigned long)descriptor_size,
    > + (unsigned long)descriptor_version,
    > + (unsigned long)virtual_map);
    > + efi_call_phys_epilog();
    > + return status;
    > +}

    Please, Please kill this.

    As far as I can tell virtual mode is incompatible with kexec.
    It is unnecessary because none of the EFI calls are fast path.

    Further I believe that using virtual addresses is likely to
    make things more brittle.

    So please drop the EFI virtual mode nonsense.

    Thank you,
    Eric
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-06-01 20:45    [W:0.034 / U:1.892 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site