Messages in this thread | | | Date | Wed, 9 May 2007 12:29:33 +0200 | From | Jens Axboe <> | Subject | Re: [patch 8/9] lguest: the block driver |
| |
On Wed, May 09 2007, Pekka Enberg wrote: > On 5/9/07, akpm@linux-foundation.org <akpm@linux-foundation.org> wrote: > >+/* Jens gave me this nice helper to end all chunks of a request. */ > >+static void end_entire_request(struct request *req, int uptodate) > >+{ > >+ if (end_that_request_first(req, uptodate, req->hard_nr_sectors)) > >+ BUG(); > >+ add_disk_randomness(req->rq_disk); > >+ blkdev_dequeue_request(req); > >+ end_that_request_last(req, uptodate); > >+} > > Again, I would prefer this went straight into block/ll_rw_blk.c. Rene > and I am using something similar in the new Mitsumi driver although > one of us has a bug already, we're using req->nr_sectors for this...
Lets do it after it is merged, as not to create a hold-up point for lguest. Once it's in, I'll fix it up.
-- Jens Axboe
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |