[lkml]   [2007]   [May]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [patch 8/9] lguest: the block driver
On Wed, May 09 2007, Pekka Enberg wrote:
> On 5/9/07, <> wrote:
> >+/* Jens gave me this nice helper to end all chunks of a request. */
> >+static void end_entire_request(struct request *req, int uptodate)
> >+{
> >+ if (end_that_request_first(req, uptodate, req->hard_nr_sectors))
> >+ BUG();
> >+ add_disk_randomness(req->rq_disk);
> >+ blkdev_dequeue_request(req);
> >+ end_that_request_last(req, uptodate);
> >+}
> Again, I would prefer this went straight into block/ll_rw_blk.c. Rene
> and I am using something similar in the new Mitsumi driver although
> one of us has a bug already, we're using req->nr_sectors for this...

Lets do it after it is merged, as not to create a hold-up point for
lguest. Once it's in, I'll fix it up.

Jens Axboe

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

 \ /
  Last update: 2007-05-09 12:35    [W:0.081 / U:7.576 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site