Messages in this thread | | | Subject | Re: [patch 25/29] xen: Add the Xen virtual network device driver. | From | Rusty Russell <> | Date | Tue, 08 May 2007 16:42:54 +1000 |
| |
On Mon, 2007-05-07 at 23:30 -0700, Jeremy Fitzhardinge wrote: > Rusty Russell wrote: > > Looks good, you can slightly improve it to be the model use of new > > module_param types by calling your functions param_set_rx_mode and > > param_get_rx_mode, then simply using "module_param(rx_mode, rx_mode, > > 0400)" > > > > Cute. I tried it out, but it doesn't yield an obvious improvement:
Of course not, but it's the Right Way!
Thanks, Rusty.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |