lkml.org 
[lkml]   [2007]   [May]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectRe: CodingStyle: start flamewar about use of braces
    On Tue, 8 May 2007 19:03:10 GMT Linux Kernel Mailing List wrote:

    > Gitweb: http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=e659ba4a0d2d471c0d73590f78e1a1b5a1eede48
    > Commit: e659ba4a0d2d471c0d73590f78e1a1b5a1eede48
    > Parent: 28be5abb400e5e082f5225105fdc69337ec0c0b4
    > Author: Oliver Neukum <oliver@neukum.org>
    > AuthorDate: Tue May 8 00:30:34 2007 -0700
    > Committer: Linus Torvalds <torvalds@woody.linux-foundation.org>
    > CommitDate: Tue May 8 11:15:12 2007 -0700
    >
    > CodingStyle: start flamewar about use of braces

    It worked somewhat. We never did reach any kind of
    concensus about this....


    > Signed-off-by: Oliver Neukum <oneukum@suse.de>
    > Cc: Tilman Schmidt <tilman@imap.cc>
    > Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
    > Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
    > ---
    > Documentation/CodingStyle | 15 +++++++++++++++
    > 1 files changed, 15 insertions(+), 0 deletions(-)
    >
    > diff --git a/Documentation/CodingStyle b/Documentation/CodingStyle
    > index 9069189..e7f5fc6 100644
    > --- a/Documentation/CodingStyle
    > +++ b/Documentation/CodingStyle
    > @@ -160,6 +160,21 @@ supply of new-lines on your screen is not a renewable resource (think
    > 25-line terminal screens here), you have more empty lines to put
    > comments on.
    >
    > +Do not unnecessarily use braces where a single statement will do.
    > +
    > +if (condition)
    > + action();
    > +
    > +This does not apply if one branch of a conditional statement is a single
    > +statement. Use braces in both branches.
    > +
    > +if (condition) {
    > + do_this();
    > + do_that();
    > +} else {
    > + otherwise();
    > +}
    > +
    > 3.1: Spaces
    >
    > Linux kernel style for use of spaces depends (mostly) on


    ---
    ~Randy
    *** Remember to use Documentation/SubmitChecklist when testing your code ***
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-05-08 21:41    [W:0.025 / U:0.116 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site