lkml.org 
[lkml]   [2007]   [May]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/3] WAN Kconfig: change "depends on HDLC" to "select"
    Hi,

    On Mon, 7 May 2007, Jeff Garzik wrote:

    > > select seriously screws with the dependencies, it's especially problematic
    > > if the selected symbol has other dependencies as HDLC in this case, it makes
    > > it only more complicated to get the dependencies correct again.
    > > Please use it only if it solves a real problem.
    >
    > What he's doing is the standard way to deal with library-style code. Nothing
    > wrong with the patch, it's continuing established methods.

    select was never meant as autoconfiguration tool. It can't be said often
    enough: select seriously screws with the dependencies, _please_ don't use
    it as a simple depends replacement.
    HDLC doesn't really look like simple library code, what's up with all the
    HDLC_* options?

    bye, Roman
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-05-07 15:49    [W:4.092 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site