Messages in this thread | | | Date | Mon, 7 May 2007 15:46:08 +0200 (CEST) | From | Roman Zippel <> | Subject | Re: [PATCH 1/3] WAN Kconfig: change "depends on HDLC" to "select" |
| |
Hi,
On Mon, 7 May 2007, Jeff Garzik wrote:
> > select seriously screws with the dependencies, it's especially problematic > > if the selected symbol has other dependencies as HDLC in this case, it makes > > it only more complicated to get the dependencies correct again. > > Please use it only if it solves a real problem. > > What he's doing is the standard way to deal with library-style code. Nothing > wrong with the patch, it's continuing established methods.
select was never meant as autoconfiguration tool. It can't be said often enough: select seriously screws with the dependencies, _please_ don't use it as a simple depends replacement. HDLC doesn't really look like simple library code, what's up with all the HDLC_* options?
bye, Roman - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |