lkml.org 
[lkml]   [2007]   [May]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH 3/3] Intel IXP4xx network drivers
    Date
    On 7 May 2007, at 01:07, Krzysztof Halasa wrote:

    > Adds IXP4xx drivers for built-in CPU components:
    > - hardware queue manager
    > - NPE (network coprocessors),
    > - Ethernet ports,
    > - HSS (sync serial) ports (currently only non-channelized HDLC).
    >
    > Both Ethernet and HSS drivers use queue manager and NPE driver and
    > require external firmware file(s) available from www.intel.com.
    >
    > "Platform device" definitions for Ethernet ports on IXDP425
    > development
    > platform are provided (though it has been tested on not yet available
    > IXP425-based hardware only)
    >
    > Signed-off-by: Krzysztof Halasa <khc@pm.waw.pl>

    Immediate comments as follows:

    (Krzysztof has already seen them in a private email but I'm putting
    them out so people can publically disagree with me if I have got this
    wrong.)

    Code placement:
    Queue Manager & NPE code => arch/arm/mach-ixp4xx
    WAN driver code => drivers/net/wan
    Eth code => drivers/net/arm

    Kconfig:
    I'm not convinced about 'config IXP4XX_NETDEVICES'. I'd lose it
    together with the drivers/net/ixp4xx directory
    Ethernet & HSS code should probably select NPE and QMGR (rather than
    depend) but these options should still be exposed in arch/arm/mach-
    ixp4xx/Kconfig

    Michael-Luke Jones

    PS: Please cc me on replies as I only subscribe to l-a-k.
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-05-07 15:31    [W:0.022 / U:0.880 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site