lkml.org 
[lkml]   [2007]   [May]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/6] firewire: char device interface
Christoph Hellwig wrote:
> On Wed, May 02, 2007 at 05:11:45PM -0400, Kristian H??gsberg wrote:
>> The firewire-cdev.h file is meant to be a self-contained userspace header
>> file and shouldn't include other kernel header files. All duplicated
>> values are standardized ieee1394 values and won't ever change. I should
>> put a #ifndef __FW_COMMON_DEFINES protection around the duplicate values, I
>> guess, but I'm just wondering why I never saw a "symbol redefined"
>> warning...
>
> No, defining things in two places is not okay. Just add a new header
> that defines these protocol constants, which needs to be included by
> userspace that wants to use them.

Ok, I split out the shared constants into linux/firewire-constants.h which
gets included by linux/firewire-cdev.h.

Kristian

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-05-08 02:23    [W:0.090 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site