Messages in this thread | | | From | "Rafael J. Wysocki" <> | Subject | Re: [PATCH -mm] PM: Separate hibernation code from suspend code | Date | Sat, 5 May 2007 12:16:38 +0200 |
| |
On Saturday, 5 May 2007 08:31, Andrew Morton wrote: > On Fri, 4 May 2007 11:32:31 +0200 "Rafael J. Wysocki" <rjw@sisk.pl> wrote: > > > Separate the hibernation (aka suspend to disk code) from the other suspend code. > > In particular: > > * Remove the definitions related to hibernation from include/linux/pm.h > > * Introduce struct hibernation_ops and a new hibernate() function to hibernate > > the system, defined in include/linux/suspend.h > > * Separate suspend code in kernel/power/main.c from hibernation-related code > > in kernel/power/disk.c and kernel/power/user.c (with the help of > > hibernation_ops) > > * Switch ACPI (the only user of pm_ops.pm_disk_mode) to hibernation_ops > > This causes the long-suffering Vaio to fail to power off during suspend > to disk. It says "Please power me down manually".
Hmm, looks like a failure of acpi_hibernation_enter(). Can you please put a printk() in there, after local_irq_restore()?
> <debugs a bit> > > machine_ops.halt(); points at native_machine_halt(), which is a no-op. > > However `halt -p' still works OK. How come it is not similarly affected?
'halt -p' probably uses acpi_power_off() (which calls acpi_enter_sleep_state(ACPI_STATE_S5)) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |