lkml.org 
[lkml]   [2007]   [May]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [-mm patch] do_revoke error handling (was Re: 2.6.21-mm1)
    On Sat, May 05, 2007 at 01:49:55AM -0700, Andrew Morton wrote:
    > >
    > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.21/2.6.21-mm1/
    > >
    > fs/revoke.c: In function 'do_revoke':
    > fs/revoke.c:563: warning: 'details.fset' may be used uninitialized in this function
    > fs/revoke.c:563: warning: 'details.restore_start' may be used uninitialized in this function

    On Sat, 5 May 2007, Frederik Deweerdt wrote:
    > It seems that we should goto 'out_free_table' if an error happens in
    > the mainloop. Otherwise 'details' is passed to restore_files() without
    > being initialized.

    Good catch. The patch is wrong, though. Wwe must restore the file
    descriptors in case revoke fails; otherwise we'll leave non-revoked files
    hanging. The proper fix is to move initialization before the
    do_each_thread() bit. Care to make a new patch, Frederik?

    Pekka
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-05-05 23:25    [W:0.019 / U:0.156 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site