lkml.org 
[lkml]   [2007]   [May]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: 2.6.21-mm1
    On Sat, 05 May 2007 17:48:28 +0200 Maciej Rutecki <maciej.rutecki@gmail.com> wrote:

    > Andrew Morton pisze:
    > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.21/2.6.21-mm1/
    > >
    > >
    >
    > CC [M] lib/zlib_deflate/deflate_syms.o
    > LD [M] lib/zlib_deflate/zlib_deflate.o
    > Building modules, stage 2.
    > MODPOST 791 modules
    > ERROR: "ssb_pcihost_register" [drivers/net/b44.ko] undefined!
    > ERROR: "ssb_pcihost_unregister" [drivers/net/b44.ko] undefined!
    > make[2]: *** [__modpost] Error 1
    > make[1]: *** [modules] Error 2
    > make[1]: Leaving directory `/usr/src/linux-mm'
    > make: *** [debian/stamp-build-kernel] Error 2
    >
    > Config:
    > http://www.unixy.pl/maciek/download/kernel/2.6.21-mm1/config-2.6.21-mm1.gz
    >

    OK, thanks. I assume that's a Kconfig mistake in the wireless tree.

    But it looks like a real minefield:


    +static inline void b44_pci_exit(void)
    +{
    +#ifdef CONFIG_B44_PCI
    + ssb_pcihost_unregister(&b44_pci_driver);
    +#endif
    +}

    and

    +#ifdef CONFIG_BCM43XX_MAC80211_PCI
    + ssb_pcihost_unregister(&bcm43xx_pci_driver);
    +#endif

    and

    +#ifdef CONFIG_SSB_PCIHOST
    +/* PCI-host wrapper driver */
    +extern int ssb_pcihost_register(struct pci_driver *driver);
    +static inline void ssb_pcihost_unregister(struct pci_driver *driver)
    +{
    + pci_unregister_driver(driver);
    +}
    +#endif /* CONFIG_SSB_PCIHOST */


    That looks waaaaaay more complicated than it needs to be.

    I'm thinking that the first two ifdefs should be removed and that third one
    needs a #else clause which implements stubs and that b44 Kconfig needs to
    be taught about CONFIG_SSB_PCIHOST in some fashion.

    Or something like that.
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-05-05 20:51    [W:0.026 / U:121.012 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site