lkml.org 
[lkml]   [2007]   [May]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [patch 9/9] Scheduler profiling - Use conditional calls
    On Wed, May 30, 2007 at 10:00:34AM -0400, Mathieu Desnoyers wrote:
    >>> + if (prof_on)
    >>> + BUG_ON(cond_call_arm("profile_on"));

    * William Lee Irwin III (wli@holomorphy.com) wrote:
    >> What's the point of this BUG_ON()? The condition is a priori impossible.

    On Thu, May 31, 2007 at 05:12:58PM -0400, Mathieu Desnoyers wrote:
    > Not impossible: hash_add_cond_call() can return -ENOMEM if kmalloc lacks
    > memory.

    Shouldn't it just propagate the errors like anything else instead of
    going BUG(), then? One can easily live without profiling if the profile
    buffers should fail to be allocated e.g. due to memory fragmentation.

    These things all have to handle errors for hotplugging anyway AIUI.


    -- wli
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-06-01 01:43    [W:0.021 / U:34.780 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site