lkml.org 
[lkml]   [2007]   [May]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [RFC 2/4] CONFIG_STABLE: Switch off kmalloc(0) tests in slab allocators
From
Date
Zach Brown <zach.brown@oracle.com> writes:

> > +#ifndef CONFIG_STABLE
> > /*
> > * We should return 0 if size == 0 (which would result in the
> > * kmalloc caller to get NULL) but we use the smallest object
> > @@ -81,6 +82,7 @@ static inline int kmalloc_index(size_t s
> > * we can discover locations where we do 0 sized allocations.
> > */
> > WARN_ON_ONCE(size == 0);
> > +#endif
>
> > +#ifndef CONFIG_STABLE
> > WARN_ON_ONCE(size == 0);
> > +#endif
>
> I wonder if there wouldn't be value in making a WARN_*() variant that
> contained the ifdef internally so we could lose these tedious
> surrounding ifdefs in call sites. WARN_DEVELOPER_WHEN(), or something.
> I don't care what it's called.

Networking has had NETDEBUG(codeblock) for this. Perhaps something
similar would be useful (DEVELOPMENT(codeblock)) in addition
to the special WARN/BUG_ONs

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-05-31 23:43    [W:0.081 / U:0.348 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site