lkml.org 
[lkml]   [2007]   [May]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] drivers/block/ub.c: use list_for_each_entry()
On Wed, 30 May 2007 16:42:41 -0700, Roland Dreier <rdreier@cisco.com> wrote:

> If I just see
>
> for (pos = list_entry((head)->next, typeof(*pos), member),
> n = list_entry(pos->member.next, typeof(*pos), member);
> &pos->member != (head);
> pos = n, n = list_entry(n->member.next, typeof(*n), member))
>
> then what am I to think?

You won't catch me writing this kind of crap, so the question is moot.
Seriously, a comma operator? Admit it, you just expanded a marcro from
list.h by hand. Real people cannot write like that.

-- Pete
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-05-31 02:07    [W:0.065 / U:1.832 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site