Messages in this thread | | | Subject | Re: [PATCH] drivers/block/ub.c: use list_for_each_entry() | From | Roland Dreier <> | Date | Wed, 30 May 2007 16:14:01 -0700 |
| |
> The negative is the sheer number of helper functions in list.h. Personally, > I find it difficult to retain a working knowledge of them. Iterators are > particularly nasty that way. I'm thinking about dropping all of these > list_for_each_with_murky_argument_requirements_and_odd_side_effects() > and use plain for(;;), as a courtesy to someone who has to read the > code years down the road.
I think I disagree with this reasoning. If I'm reading your code and I see, say, list_for_each_entry_safe(), I can be pretty confident that your loop works correctly. If you write your own for loop, then I have to check that you actually got the linked list walking right.
- R. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |