Messages in this thread | | | Date | Wed, 30 May 2007 13:59:27 -0700 | From | William Lee Irwin III <> | Subject | Re: [patch 9/9] Scheduler profiling - Use conditional calls |
| |
On Wed, May 30, 2007 at 10:00:34AM -0400, Mathieu Desnoyers wrote: > Use conditional calls with lower d-cache hit in optimized version as a > condition for scheduler profiling call. [...] > + if (prof_on) > + BUG_ON(cond_call_arm("profile_on"));
What's the point of this BUG_ON()? The condition is a priori impossible.
On Wed, May 30, 2007 at 10:00:34AM -0400, Mathieu Desnoyers wrote: > - profile_hit(SCHED_PROFILING, __builtin_return_address(0)); > + cond_call(profile_on, > + profile_hit(SCHED_PROFILING, __builtin_return_address(0)));
It'd probably be prettier to stuff cond_call() inside a macro that does something like this named profile_hit() with the old profile_hit() renamed to __profile_hit() etc. Otherwise fine.
-- wli - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |