lkml.org 
[lkml]   [2007]   [May]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/6] sysfs: implement sysfs flags and SYSFS_FLAG_REMOVED
Cornelia Huck wrote:
> On Tue, 29 May 2007 01:36:26 +0900,
> Tejun Heo <htejun@gmail.com> wrote:
>
>> Rename sysfs_dirent->s_type to s_flags, pack type into lower eight
>> bits and use the rest for flags. sysfs_type() can used to access the
>> type. This patch also implements SYSFS_FLAG_REMOVED which is used to
>> improve sanity check in sysfs_deactivate(). The flag will also be
>> used to make directory entries reclamiable.
>>
>> Signed-off-by: Tejun Heo <htejun@gmail.com>
>> ---
>> fs/sysfs/dir.c | 37 +++++++++++++++++++++++--------------
>> fs/sysfs/inode.c | 5 +++--
>> fs/sysfs/mount.c | 2 +-
>> fs/sysfs/sysfs.h | 7 ++++++-
>> include/linux/sysfs.h | 4 ++++
>> 5 files changed, 37 insertions(+), 18 deletions(-)
>
> This seems sane, but I'd split this into two patches: One introducing
> sysfs_type(), and one adding SYSFS_FLAG_REMOVED.

Yeap, I would too. :-) I'll split them up on next posting.

--
tejun
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-05-30 15:49    [W:0.091 / U:0.240 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site