Messages in this thread Patch in this message | | | Date | Thu, 3 May 2007 14:19:51 -0700 | From | Andrew Morton <> | Subject | Re: [PATCH 2/2] rename thread_info to stack |
| |
On Tue, 1 May 2007 02:10:34 +0200 (CEST) Roman Zippel <zippel@linux-m68k.org> wrote:
> This finally renames the thread_info field in task structure to stack, > so that the assumptions about this field are gone and archs have more > freedom about placing the thread_info structure.
It needed this build fix:
--- a/include/asm-x86_64/system.h~rename-thread_info-to-stack-fix +++ a/include/asm-x86_64/system.h @@ -39,7 +39,7 @@ [threadrsp] "i" (offsetof(struct task_struct, thread.rsp)), \ [ti_flags] "i" (offsetof(struct thread_info, flags)),\ [tif_fork] "i" (TIF_FORK), \ - [thread_info] "i" (offsetof(struct task_struct, thread_info)), \ + [thread_info] "i" (offsetof(struct task_struct, stack)), \ [pda_pcurrent] "i" (offsetof(struct x8664_pda, pcurrent)) \ : "memory", "cc" __EXTRA_CLOBBER) _
It is unpleasing that this code is forced to implicitly assume that the thing pointed to by task_struct.stack has type `struct thread_info'.
Are we sure this patch is a good thing? - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |