lkml.org 
[lkml]   [2007]   [May]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch] CFS scheduler, -v7
Hi, Ingo

I wrote that email in a hurry, therefore might not explain the
problem clearly. However I do think there is a problem for this part,
after I carefully read the code again. Now I want to try again :-)
Hopefully, this time I will do a right job.

Starting from the following code:

+ if (__delta > niced_granularity(rq, curr, granularity))
+ resched_task(curr);


Suppose, "curr" has nice value -10, then curr->load_shift = 15.
Granularity passed into this function is
fixed 2,000,000 (for CFS -v8). Let's just divide everything by 1,000,000
for simplicity, say granularity used is 2.

Now, we look at how granularity is rescaled:

+ int load_shift = p->load_shift;
+
+ if (load_shift == SCHED_LOAD_SHIFT)
+ return value;
+
+ return (value << load_shift) >> SCHED_LOAD_SHIFT;

it returns (2 << 15) >> 10 = 2 * 32 = 64, therefore __delta has to be
larger than 64 so that the current process can be preempted.

Suppose, "curr" executes for 1 tick, an timer interrupts comes. It
executes about 1,000,000 (roughly speaking, since timer interrupts come
1000/second). Since we divided everything by 1,000,000, it becomes 1 in
this discussion. After this execution, how much will "curr" increments
its fair_key?
It is weighted: 1/32.

then how much time is needed for "curr" to build a 2 * 32 difference on
fair_key, with every 1 ms it updates fair_key by 1/32 ? 2 * 32 * 32 !
On the other hand, for a task has nice value 1, the amount work needed
to preemption is 2 * 1 *1.
If we have only 2 task running, p1 with nice value -10, p2 with nice
value 0.
p1 get cup share: (32 * 32) / (32 * 32 + 1 *1)
p2 get cpu share: ( 1* 1) / (32 * 32 + 1 * 1)

I do see a quadratic effect here. Did I missed anything? sorry to bother
you again, I just want to help :-)

Thanks a lot !

Ting




-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-05-03 18:05    [W:0.039 / U:0.076 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site