lkml.org 
[lkml]   [2007]   [May]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/5] lockdep: sanitise CONFIG_PROVE_LOCKING

* Christoph Hellwig <hch@infradead.org> wrote:

> On Tue, May 29, 2007 at 02:52:50PM +0200, Peter Zijlstra wrote:
> > Ensure that all of the lock dependency tracking code is under
> > CONFIG_PROVE_LOCKING. This allows us to use the held lock tracking code
> > for other purposes.
>
> There's an awfull lot of ifdefs introduced in this patch, I wonder
> whether it might be better to split up lockdep.c at those boundaries.

it adds 6 new #ifdefs. There's 35 #ifdefs in page_alloc.c, 44 in
sysctl.c and 64 in sched.c. I'd not call it 'an awful lot', although
certainly it could be reduced. Splitting lockdep.c up would uglify it
well beyond the impact of the 6 #ifdefs, given the amount of glue
needed.

Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-05-29 16:19    [W:0.074 / U:0.044 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site