lkml.org 
[lkml]   [2007]   [May]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/1] V4L: stk11xx, add a new webcam driver
    Jiri Slaby wrote:
    > On 5/24/07, Markus Rechberger <mrechberger@gmail.com> wrote:
    >> On 5/24/07, Jiri Slaby <jirislaby@gmail.com> wrote:
    > [...]
    >> > +static int stk1125_camera_asleep(struct stk11xx *dev)
    >> > +{
    >> > + int value;
    >> > +
    >> > + stk11xx_read_registry(dev, 0x0104, &value);
    >> > + stk11xx_read_registry(dev, 0x0105, &value);
    >> > + stk11xx_read_registry(dev, 0x0106, &value);
    >> > +
    >>
    >> why do you read these values (this is also something in the ongoing
    >> code I see, the read value just gets overwritten all the time)?
    >
    > Well, as I tested, reads are neccesary, otherwise it doesn't work. And
    > when they are needed, you need to read the value to some place in
    > memory -- the &value.

    Perhaps a few comments are warranted here and there about why some of
    those less obvious things are done.

    Or do it as more or less self-documenting code like

    static inline void
    stk11xx_unjam_registry(struct stk11xx *dev, u16 index)
    {
    int dummy;

    stk11xx_read_registry(dev, index, &dummy);
    }

    --
    Stefan Richter
    -=====-=-=== -=-= ==--=
    http://arcgraph.de/sr/
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-05-25 10:25    [W:0.021 / U:2.008 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site