lkml.org 
[lkml]   [2007]   [May]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] Make prepare_namespace() wait for devices
    Andrew Morton wrote:
    > Whatever. I think you can work it out ;)
    >
    >

    Bare with me, I just woke up ;)

    > while (driver_probe_done() || (ROOT_DEV = name_to_dev_t(...)) == 0)
    >
    > perhaps?
    >
    > The loop-which-sleeps within a loop-which-sleeps seems poorly thought out?
    >

    I'd say a matter of taste. I'm not a big fan och cramming things into
    the while() clause.

    The idea with the double loops was to keep this thread asleep when we
    could detect meaningful work elsewhere in the kernel. You could just
    remove the inner-most loop if it offends you. :)

    Rgds

    --
    -- Pierre Ossman

    Linux kernel, MMC maintainer http://www.kernel.org
    PulseAudio, core developer http://pulseaudio.org
    rdesktop, core developer http://www.rdesktop.org

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-05-25 06:35    [W:0.027 / U:0.824 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site