| Subject | Re: [patch 1/7] ps3: Preallocate bootmem memory for the PS3 FLASH ROM storage driver | From | Benjamin Herrenschmidt <> | Date | Sat, 26 May 2007 08:35:39 +1000 |
| |
On Fri, 2007-05-25 at 10:36 +0200, Geert.Uytterhoeven@sonycom.com wrote: > -#if defined(CONFIG_FB_PS3) || defined(CONFIG_FB_PS3_MODULE) > +#if defined(CONFIG_FB_PS3) || defined(CONFIG_FB_PS3_MODULE) || \ > + defined(CONFIG_PS3_FLASH_MODULE) || > defined(CONFIG_PS3_FLASH_MODULE)
As I said multiple times, imho, #ifdef CONFIG_xxx_MODULE in the kernel is always a bug.
You should always be able to build the module out of tree afteward and use it on a kernel that didn't have the CONFIG_xxx_MODULE set imho.
Ben.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|