Messages in this thread | | | Date | Fri, 25 May 2007 09:41:36 -0700 | From | Andrew Morton <> | Subject | Re: [PATCH] potential parse error in ifdef |
| |
On Fri, 25 May 2007 13:50:37 +0200 (CEST) Jiri Kosina <jikos@jikos.cz> wrote:
> On Fri, 25 May 2007, Yoann Padioleau wrote: > > > I have made a tool to parse the kernel that does not pre-process the > > source. That means that my parser tries to parse all the code, including > > code in the #else branch or code that is not often compiled because > > the driver is not very used (or not used at all). So, my parser > > sometimes reports parse error not originally detected by gcc. > > Here is my (first) patch. > > drivers/char/watchdog/ixp2000_wdt.c | 2 +- > > drivers/mtd/devices/pmc551.c | 2 +- > > drivers/mtd/nand/autcpu12.c | 2 +- > > drivers/mtd/nand/ppchameleonevb.c | 2 +- > > drivers/net/amd8111e.c | 2 +- > > drivers/net/skfp/smt.c | 2 +- > > drivers/scsi/aic7xxx/aic79xx_core.c | 2 +- > > sound/arm/sa11xx-uda1341.c | 2 +- > > 8 files changed, 8 insertions(+), 8 deletions(-) > > As these are totally independent fixes across various subsystems, you > should probably split the patch into per-subsystem patches and submit them > separately.
That's normally true, yes. But for a bunch of obviously-better one-line fixes in code which nobody has even compiled in ages, I think we can bend the rules a bit and just slam it in.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |