Messages in this thread | | | Date | Fri, 25 May 2007 11:10:23 -0400 | From | "Tej Parkash" <> | Subject | Reg: redundancy in inet socket |
| |
list_for_each_rcu(p, &inetsw[sock->type]) { answer = list_entry(p, struct inet_protosw, list);
/* Check the non-wild match. */ if (protocol == answer->protocol) { if (protocol != IPPROTO_IP) break; } else { /* Check for the two wild cases. */ if (IPPROTO_IP == protocol) { protocol = answer->protocol; break; } if (IPPROTO_IP == answer->protocol) break; }
i think there is a problem in this code because if (protocol == answer->protocol) will be more like an assignment rather then comparison pl cc to me. TEJ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |