Messages in this thread | | | Date | Thu, 24 May 2007 23:15:56 -0400 | From | Jeff Garzik <> | Subject | Re: [patch 1/7] libata: check for AN support |
| |
Kristen Carlson Accardi wrote: > Check to see if an ATAPI device supports Asynchronous Notification. > If so, enable it. > > Signed-off-by: Kristen Carlson Accardi <kristen.c.accardi@intel.com> > --- > Andrew, I cleaned up the function header to properly comply with kernel > doc requirements. Other than that, this patch is the same.
I would ask for a simple revision: update ata_dev_set_AN() such that it takes a second argument 'enable'. This boolean indicates to the function whether SETFEATURES_SATA_ENABLE or SETFEATURES_SATA_DISABLE should be passed to the device.
Otherwise than that, it's ready to merge I would say.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |