Messages in this thread | | | Date | Thu, 24 May 2007 13:27:37 -0700 (PDT) | From | Linus Torvalds <> | Subject | Re: pcmcia resume 60 second hang. Re: [patch 00/69] -stable review |
| |
On Thu, 24 May 2007, Pavel Machek wrote: > > If someone does request_firmware from resume function... that's > bad. Resume function should be fixed. Pcmcia? ti12xx driver?
Probably pcmcia "ds" driver and CONFIG_PCMCIA_LOAD_CIS.
> Well. we'd like to present hardware in working state as soon as we > resume (if eth0 was there before resume, it should be there after > resume. not 3 seconds after resume); so if someone needs to load the > firmware, they should just store it in the kernel memory, and load it > during boot or during (very early) suspend.
Equally arguably, we should just have a "resume_late()" call that can be used to do this after everything is up and running.
And quite frankly, I don't actually see any reason why firmware loading shouldn't work in the resume path. I really do think that this is ANOTHER bug that has no other reason than the fact that that f*cking freezer killed the system for no really good reason.
Linus - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |