lkml.org 
[lkml]   [2007]   [May]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH]: UDF code style conversion to kernel style
On Thu, 24 May 2007 21:47:42 +0300 Pekka Enberg wrote:

> Hi Cyrill,
>
> On 5/23/07, Cyrill Gorcunov <gorcunov@gmail.com> wrote:
> > @@ -2103,7 +1944,7 @@ long udf_block_map(struct inode *inode, sector_t block)
> > kernel_lb_addr eloc;
> > uint32_t elen;
> > sector_t offset;
> > - struct extent_position epos = { NULL, 0, { 0, 0}};
> > + struct extent_position epos = {};
>
> Bits like these in the middle of indentation fixes makes me feel
> uneasy. Could we simply ask Andrew to run Lindent on the UDF sources
> at some convinient point and push those to Linus like we did with
> mm/slab.c if I recall correctly? Its safer to do cleanups like these
> after that.

but Lindent needs some hand-holding / eyeball help as well...

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-05-24 21:03    [W:0.870 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site