Messages in this thread | | | Date | Thu, 24 May 2007 09:23:36 -0700 | From | Andrew Morton <> | Subject | Re: [PATCH 1/2] limit print_fatal_signal() rate (was: [RFC] log out-of-virtual-memory events) |
| |
On Thu, 24 May 2007 11:55:03 +0200 Ingo Molnar <mingo@elte.hu> wrote:
> > * Andrew Morton <akpm@linux-foundation.org> wrote: > > > On Thu, 24 May 2007 09:58:35 +0200 Ingo Molnar <mingo@elte.hu> wrote: > > > > > > > > * Andrew Morton <akpm@linux-foundation.org> wrote: > > > > > > > Well OK. But vdso-print-fatal-signals.patch is designated > > > > not-for-mainline anyway. > > > > > > btw., why? > > > > err, because that's what I decided a year ago. I wonder why ;) > > > > Perhaps because of the DoS thing, but it has a /proc knob and defaults > > to off, so it should be OK. > > yeah. There's also a boot option. To address the DoS angle, should i > make it optionally printk_ratelimit() perhaps? (although often the > messages come in streams and skipping a message can be annoying)
I don't think so, really. It takes a deliberate act to turn the thing on, after all.
I we _were_ concerned about the logspam then it might be better to make the feature turn itself off after 100 messages, rather than ratelimiting it. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |