[lkml]   [2007]   [May]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Patch in this message
Subject[patch 69/69] CRYPTO: api: Read module pointer before freeing algorithm
-stable review patch.  If anyone has any objections, please let us know.

From: Herbert Xu <>

The function crypto_mod_put first frees the algorithm and then drops
the reference to its module. Unfortunately we read the module pointer
which after freeing the algorithm and that pointer sits inside the
object that we just freed.

So this patch reads the module pointer out before we free the object.

Thanks to Luca Tettamanti for reporting this.

Signed-off-by: Herbert Xu <>
Signed-off-by: Chris Wright <>

crypto/api.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

--- linux-
+++ linux-
@@ -48,8 +48,10 @@ EXPORT_SYMBOL_GPL(crypto_mod_get);

void crypto_mod_put(struct crypto_alg *alg)
+ struct module *module = alg->cra_module;
- module_put(alg->cra_module);
+ module_put(module);

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

 \ /
  Last update: 2007-05-21 21:39    [W:0.286 / U:4.336 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site