| Date | Mon, 21 May 2007 12:16:22 -0700 | From | Chris Wright <> | Subject | [patch 10/69] kbuild: fixdep segfault on pathological string-o-death |
| |
-stable review patch. If anyone has any objections, please let us know. ---------------------
From: Andy Green <andy@warmcat.com>
build scripts: fixdep blows segfault on string CONFIG_MODULE seen
The string "CONFIG_MODULE" appearing anywhere in a source file causes fixdep to segfault. This string appeared in the wild in the current mISDN sources (I think they meant CONFIG_MODULES). But it shouldn't segfault (esp as CONFIG_MODULE appeared in a quoted string).
Signed-off-by: Andy Green <andy@warmcat.com> Signed-off-by: Sam Ravnborg <sam@ravnborg.org> Signed-off-by: Chris Wright <chrisw@sous-sol.org> ---
This is not an important fix per see - but I do not like SEGV during compilation... Will be pushed to Linus today.
Sam
scripts/basic/fixdep.c | 2 ++ 1 file changed, 2 insertions(+)
--- linux-2.6.21.1.orig/scripts/basic/fixdep.c +++ linux-2.6.21.1/scripts/basic/fixdep.c @@ -249,6 +249,8 @@ void parse_config_file(char *map, size_t found: if (!memcmp(q - 7, "_MODULE", 7)) q -= 7; + if( (q-p-7) < 0 ) + continue; use_config(p+7, q-p-7); } } -- - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|