lkml.org 
[lkml]   [2007]   [May]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    SubjectRe: [2.6 patch] drivers/net/wireless/libertas/rx.c: fix use-after-free
    From
    <quote sender="John W. Linville">
    > On Sat, May 19, 2007 at 11:14:10AM +0800, Eugene Teo wrote:
    > > John W. Linville wrote:
    >
    > > >> done:
    > > >> LEAVE();
    > > >>
    > > >> - skb->protocol = __constant_htons(0x0019); /* ETH_P_80211_RAW */
    > > >> -
    > > >
    > > > Except for this part...is this intentional?
    > >
    > > skb could have been freed by then. And, in libertas_upload_rx_packet(), skb->protocol
    > > is initialized by eth_type_trans(skb, priv->wlan_dev.netdev).
    >
    > OK, I see that. Looks like Florin has reposted his patch, still
    > without this hunk. Would you like to submit a patch for this hunk?

    skb could have been freed by then. Also, in libertas_upload_rx_packet(),
    skb->protocol is initialized by eth_type_trans().

    Cc: John W. Linville <linville@tuxdriver.com>
    Signed-off-by: Eugene Teo <eugeneteo@kernel.sg>
    ---

    diff -uprN -X 2.6.22-rc2/Documentation/dontdiff 2.6.22-rc2.default/drivers/net/wireless/libertas/rx.c 2.6.22-rc2/drivers/net/wireless/libertas/rx.c
    --- 2.6.22-rc2.default/drivers/net/wireless/libertas/rx.c 2007-05-21 22:07:50.000000000 +0800
    +++ 2.6.22-rc2/drivers/net/wireless/libertas/rx.c 2007-05-21 22:08:44.000000000 +0800
    @@ -453,7 +453,5 @@ static int process_rxed_802_11_packet(wl
    done:
    LEAVE();

    - skb->protocol = __constant_htons(0x0019); /* ETH_P_80211_RAW */
    -
    return (ret);
    }
    --
    1024D/58DF8823 print 47B9 90F6 AE4A 9C51 37E0 D6E1 EA84 C6A2 58DF 8823
    main(i) { putchar(182623909 >> (i-1) * 5&31|!!(i<7)<<6) && main(++i); }
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/
    \
     
     \ /
      Last update: 2007-05-21 16:33    [W:0.118 / U:0.156 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site