lkml.org 
[lkml]   [2007]   [May]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] i386, x86-64: show that CONFIG_HOTPLUG_CPU is required for suspend on SMP
    Date
    From: Stefan Richter <stefanr@s5r6.in-berlin.de>

    It's not sufficiently documented that CONFIG_HOTPLUG_CPU is required for
    suspend/hibernation on SMP.

    Point out the non-obvious.

    Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
    Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
    ---
    arch/i386/Kconfig | 2 +-
    arch/x86_64/Kconfig | 7 +++++--
    2 files changed, 6 insertions(+), 3 deletions(-)

    Index: linux-2.6.22-rc2/arch/i386/Kconfig
    ===================================================================
    --- linux-2.6.22-rc2.orig/arch/i386/Kconfig
    +++ linux-2.6.22-rc2/arch/i386/Kconfig
    @@ -891,7 +891,7 @@ config PHYSICAL_ALIGN
    Don't change this unless you know what you are doing.

    config HOTPLUG_CPU
    - bool "Support for hot-pluggable CPUs (EXPERIMENTAL)"
    + bool "Support for suspend on SMP and hot-pluggable CPUs (EXPERIMENTAL)"
    depends on SMP && HOTPLUG && EXPERIMENTAL && !X86_VOYAGER
    ---help---
    Say Y here to experiment with turning CPUs off and on, and to
    Index: linux-2.6.22-rc2/arch/x86_64/Kconfig
    ===================================================================
    --- linux-2.6.22-rc2.orig/arch/x86_64/Kconfig
    +++ linux-2.6.22-rc2/arch/x86_64/Kconfig
    @@ -428,12 +428,15 @@ config NR_CPUS
    memory in the static kernel configuration.

    config HOTPLUG_CPU
    - bool "Support for hot-pluggable CPUs (EXPERIMENTAL)"
    + bool "Support for suspend on SMP and hot-pluggable CPUs (EXPERIMENTAL)"
    depends on SMP && HOTPLUG && EXPERIMENTAL
    help
    Say Y here to experiment with turning CPUs off and on. CPUs
    can be controlled through /sys/devices/system/cpu/cpu#.
    - Say N if you want to disable CPU hotplug.
    + This is also required for suspend/hibernation on SMP systems.
    +
    + Say N if you want to disable CPU hotplug and don't need to
    + suspend.

    config ARCH_ENABLE_MEMORY_HOTPLUG
    def_bool y
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/
    \
     
     \ /
      Last update: 2007-05-20 21:27    [W:0.022 / U:179.980 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site