Messages in this thread | | | Date | Wed, 2 May 2007 16:15:33 -0700 | From | Randy Dunlap <> | Subject | Re: [PATCH] lib/hexdump |
| |
On Wed, 2 May 2007 16:06:35 -0700 Andrew Morton wrote:
> On Wed, 02 May 2007 15:56:48 -0700 > Randy Dunlap <randy.dunlap@oracle.com> wrote: > > > Andrew Morton wrote: > > > On Wed, 2 May 2007 15:35:56 -0700 > > > Randy Dunlap <randy.dunlap@oracle.com> wrote: > > > > > >> From: Randy Dunlap <randy.dunlap@oracle.com> > > >> > > >> Based on ace_dump_mem() from Grant Likely for the Xilinx > > >> SystemACE CompactFlash interface. > > >> > > >> Add hex_dumper() to lib/hexdump.c and linux/kernel.h. > > >> > > >> This patch adds the function 'hex_dumper' which can be used to perform a > > >> hex + ASCII dump of data to syslog, in an easily viewable format, thus > > >> providing a common text hex dump format. > > >> > > >> It does not provide a hexdump_to_buffer() function. > > >> if someone needs that, we'll have to add it. > > >> > > >> Example usage: > > >> hex_dumper(KERN_DEBUG, data, length); > > >> > > > > > > Fair enough. This is the sort of thing one could easily overdesign ;) > > > > The Intel version also returned the number of bytes printed. > > and they had a hexdump_to_buffer() for sysfs output. > > > > Yeah, that's where we get into creature feeping. Really it should be > passed the address of a function which performs the per-char output and > which is passed a bunch of args so it can do its stuff. But doing printk > of a single char at a time is a bit inefficient and produces mangled output > on SMP. And then we don't know the length of the output and we'd like it > dynamically allocated and on and on. > > Ho hum. Perhaps a middle ground is to implement hexdump-to-memory as the > core function. hex_dumper() becomes a simple wrapper around that. (but > how big is its buffer? One line would be OK, I guess)
Yeah, I almost did it that way. We'll see.
> > OK, that's one way to do it. I'll wait a bit for other comments. > > Good luck ;)
--- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |