lkml.org 
[lkml]   [2007]   [May]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [RELEASE] Lguest for 2.6.21
From
Date
On Thu, 2007-05-03 at 03:33 +0800, WANG Cong wrote:
> Hi Rusty!
>
> I found you forgot to check the return value of copy_from_user, and
> here is the fix for drivers/lguest/interrupts_and_traps.c.
>
> Signed-off-by: WANG Cong <xiyou.wangcong@gmail.com>

Hi Wang!

Thanks for the patch. This omission (in several places) was
deliberate. We can't really do anything sensible if the user unmapped
the page. I assume you saw a gcc warning from this code?

We could also use lgread() in these places which does this check and
kills the guest if something goes wrong. I'll check the benchmarks to
make sure the (slight) extra overhead doesn't cause a regression...

Thanks!
Rusty.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-05-03 01:05    [from the cache]
©2003-2011 Jasper Spaans