Messages in this thread | | | Date | Wed, 2 May 2007 01:26:47 -0700 | From | Paul Jackson <> | Subject | Re: [patch] cpusets: allow empty {cpus,mems}_allowed to be set for unpopulated cpuset |
| |
Other than the detail of allowing a newline from doing:
echo > cpus
to work, I'm ok with this patch. It passes my cpuset_test, and seems to allow unpopulating cpusets, as advertised.
Aha - as I was writing this, I noticed that the command:
echo -n '' > cpus
does -not- work! The echo command recognizes that as a write of zero non-null bytes, and skips the write altogether.
We have to add the code to handle an input line consisting of just a bare newline, to mean an empty mask. Well, we don't -have- to. But writing a single nul byte in shell script will challenge most shell script hackers.
-- I won't rest till it's the best ... Programmer, Linux Scalability Paul Jackson <pj@sgi.com> 1.925.600.0401 - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |